Address minor issues causing CI to fail#1615
Merged
wshanks merged 6 commits intoqiskit-community:mainfrom Feb 18, 2026
Merged
Conversation
tox 4.36.0 started enforcing the constraint that a `package_env` environemnt only installs what is listed in `build-system.requires`. We use `pypa/build` to build the wheel from the sdist instead of building the wheel directly. `pypa/build` is used as an external command so it was not listed in `build-system/requires` and was just listed as an extra tox environemnt dependency. Now listing an extra dependency is not allowed so we install `pypa/build` in the packaging environment's commands until a cleaner solution is found. See tox-dev/tox#3687 (comment)
wshanks
force-pushed
the
tox-sdist-wheel-pkg-fix
branch
from
acc7d86 to
660c64b
Compare
This was referenced Feb 17, 2026
gaborbernat
added a commit
to tox-dev/tox
that referenced
this pull request
Feb 17, 2026
PR #3687 (fix for #3412) added a hard Fail in Pep517VenvPackager._setup_env() that rejects any deps on PEP-517 packaging environments. This broke two downstream consumers: tox-uv — Tests for editable-legacy, workspace, and no_pyproject scenarios set deps = wheel on .pkg because uv doesn't seed wheel into venvs by default (unlike virtualenv). The editable-legacy flow needs wheel importable in the packaging venv for setup.py develop. CI: https://github.com/tox-dev/tox-uv/actions/runs/22071221669 Uses package = external with deps = build on .pkg to run python -m build for sdist→wheel workflow. Discussion: #3491 (reply in thread) Fix PR: qiskit-community/qiskit-experiments#1615 Only raise the error when call_require_hooks is a subset of {"sdist", "wheel", "editable"} (standard PEP-517 types). Allow deps when editable-legacy or external is involved Fixes: #3731 <!-- Thank you for your contribution! Please, make sure you address all the checklists (for details on how see [development documentation](http://tox.readthedocs.org/en/latest/development.html#development))! --> - [x] ran the linter to address style issues (`tox -e fix`) - [x] wrote descriptive pull request text - [x] ensured there are test(s) validating the fix - [x] added news fragment in `docs/changelog` folder - [ ] updated/extended the documentation --------- Co-authored-by: Bernát Gábor <gaborjbernat@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
dcmckayibm
approved these changes
Feb 18, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
wshanks
changed the title
The new fix allows deps only for the external package flow, so we can reuse the same package environment for the external and default flows now. Also, adjust tox version bounds so that they allow a version compatible with Python 3.9.
wshanks
force-pushed
the
tox-sdist-wheel-pkg-fix
branch
from
4ac8818 to
7716c95
Compare
Merged
via the queue into
qiskit-community:main
with commit Feb 18, 2026
0b38c31
12 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change started as a fix for a change in behavior in tox but evolved into
a set of three unrelated small fixes that are all needed to get the CI to pass
again:
toxof 4.38.0 so that we pick upScope deps rejection to pure PEP-517 build types tox-dev/tox#3730 which addresses
Build dependencies should only come from build backend tox-dev/tox#3687 (comment).
Additionally,
tox-uvis added as a tox dependency for consistency sincethat is used in CI (but actually set it to !=4.36,!=4.37 since 4.38.0 requires
Python >=3.10 and this change is a precursor to the one that drops
Python 3.9).
numpy.finfo.epssincethis was also needed for the CI to pass.
incompatibility with stestr. The hope is the next release of stestr or
testtools will address the incompatibility. See:
Re-add removed helpers testing-cabal/testtools#566