CCL-2140: add per-cluster Envoy access log override - #310
Open
lakhansamani wants to merge 1 commit into
Open
Conversation
The access log is enabled per region, which is too coarse to act on during an incident: a single tenant can carry most of a region's traffic, so silencing one cluster meant giving up the log for every other cluster there. Ingress.EnableAccessLog is three-state — unset follows the region, true and false override it in either direction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CCL-2140
Summary
The Envoy access log is enabled per region (operator#981), which is too coarse to act on during an incident: in ap-south-1 one tenant carries 1216 of the region's 1404 rps, so silencing it meant giving up the log for the other 170 clusters.
Ingress.EnableAccessLogis three-state — unset follows the region,trueandfalseoverride it in either direction. Additive and optional, so no existing cluster changes behaviour.Tests
manifests / generate / fmt / fmt_imports / vet / lint / test: 0 failures, 0 lint issues.
Table test covers all five states, including the two that matter — forcing off against an enabled region and on against a disabled one — plus a JSON test that unset stays absent from the spec.