fix case insensitive lookup for custom text models#645
Open
CODING-DARSH wants to merge 1 commit into
Open
Conversation
📝 WalkthroughWalkthroughThis PR changes how Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #650
Checklist
Summary
Custom models can be registered using one casing (e.g.
Org/Model) and later instantiated using a different casing (e.g.org/model).TextEmbeddingalready resolves models case-insensitively, butCustomTextEmbeddinglater looked up the postprocessing configuration using the original user-provided model name, which could result in aKeyError.This change uses the canonical resolved model name from
self.model_description.modelwhen retrieving the postprocessing configuration.Changes
Reproduction
Before
Org/Model.TextEmbedding("org/model").KeyError.After
Org/Model.TextEmbedding("org/model").Testing
test_custom_text_model_lookup_is_case_insensitive.