Potential fix for code scanning alert no. 5: Workflow does not contain permissions#65
Merged
Potential fix for code scanning alert no. 5: Workflow does not contain permissions#65
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/qdequippe-tech/pappers-php-api/security/code-scanning/5
In general, the fix is to explicitly scope the
GITHUB_TOKENpermissions in this workflow to the minimal set needed. That can be done either at the workflow root (applies to all jobs) or per job. Since there is only a singlecheck-specjob, adding apermissionsblock under that job is clear and sufficient.The
peter-evans/create-pull-requestaction needs to push commits and open/update PRs, which requirescontents: writeandpull-requests: write. The earlier steps (checkout, composer, code generation, rector, php-cs-fixer) only read and modify the local filesystem and do not require GitHub API permissions beyond whatactions/checkoutalready uses via the same token;contents: writeis already implied by the need to push changes, so there is no additional expansion of privilege beyond what is functionally required. The best minimal configuration therefore is:This should be added under
jobs.check-spec(e.g., betweenruns-on:andsteps:) in.github/workflows/diff-spec.yml. No imports or additional methods are needed since this is a YAML workflow file and permissions are a first-class configuration key.Suggested fixes powered by Copilot Autofix. Review carefully before merging.