WIP: add bonus to multiplayer#423
Merged
geoffrey-wu merged 12 commits intoqbreader:mainfrom Feb 2, 2026
Merged
Conversation
Merge from main
…layerTossupClient, so that later on we can create ServerTossupBonusRoom and MultiplayerTossupBonusClient and reuse logic that governs multiplayer rooms add basic skletons and wiring for TossupBonusRoom and TossupBonusClient, that are just subclasses of TossupRoom and TossupClient, respectively, for now, with no new features can advance to next bonus question, still needs client support for bonuses with one user, can now go through tossup to bonuses back to tossup successfully added bonuses to multiplayer with working UI/UX added bonus timer changed bonus timer on first part to 15s instead of 10s
Member
|
I think this approach looks really good! I'll take a deeper look later but I'm happy to implement the rest of this PR |
geoffrey-wu
force-pushed
the
wip/add-bonus-to-multiplayer
branch
from
f0dd380 to
572a1c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Geoffrey -- this is a set of changes we made to add bonus round to the multiplayer tossup room.
Rather than copying the multiplayer tossup room logic to a new room, we created a common "MixIn" class that handles multiplayer logic -- ServerMultiplayerRoomMixin, and then subclassed that Mixin class with TossupBonusRoom as the room logic, to create a ServerTossupBonusRoom. Similar pattern was used for the client side.
Can you let us know if this approach works with how you'd like to maintain the code? Thanks.