Performance: use ImageData when grid has uniform axis spacing#81
Merged
banesullivan merged 19 commits intomainfrom Mar 18, 2026
Merged
Performance: use ImageData when grid has uniform axis spacing#81banesullivan merged 19 commits intomainfrom
banesullivan merged 19 commits intomainfrom
Conversation
user27182
reviewed
Jul 9, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
- Coverage 93.60% 92.90% -0.70%
==========================================
Files 11 11
Lines 657 691 +34
==========================================
+ Hits 615 642 +27
- Misses 42 49 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Merge main branch (PRs #83-#91) into perf/use-image-data - Resolve all merge conflicts, keeping main's improvements (docstrings, type annotations, CF support, Dataset accessor) - Address review feedback: use _generate_rectilinear_coords() in io.py instead of manual cumsum - Bump minimum PyVista to >=0.45 for _generate_rectilinear_coords - Update tests for ImageData return type - Add comprehensive ImageData optimization tests - Add benchmark script demonstrating ImageData vs RectilinearGrid Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Demonstrates ImageData auto-detection with the cells3d dataset, GPU-accelerated volume rendering, dual-channel visualization, uniform vs non-uniform spacing comparison, and roundtrip conversion. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Volume rendering is the primary motivation for the ImageData optimization. The benchmark now measures add_volume + render across mesh types and grid sizes, tests mapper compatibility, and shows ~1.9x speedup on the cells3d dataset. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
pv.ImageDataoverpv.RectilinearGridwhen the axes have uniform spacing.This yields significant performance improvements, especially if wanting to volume render:
The tests here are working around an upstream bug: pyvista/pyvista#7686
maintenance