Move activity_type enum <> string map to .h file (#1317)#1317
Closed
ryanzhang22 wants to merge 1 commit intopytorch:mainfrom
Closed
Move activity_type enum <> string map to .h file (#1317)#1317ryanzhang22 wants to merge 1 commit intopytorch:mainfrom
ryanzhang22 wants to merge 1 commit intopytorch:mainfrom
Conversation
|
@ryanzhang22 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97318652. |
meta-codesync
Bot
changed the title
ryanzhang22
added a commit
to ryanzhang22/kineto
that referenced
this pull request
Mar 20, 2026
Summary: A previous version of pytorch/pytorch#177532 tried to add a pybind binding for activity_type which called `libkineto::toString(ActivityType)`. Some build configurations include the Kineto headers but do not link the compiled libkineto library, which caused an undefined symbol error at load time when `toString()` is called. To get around this -- move the activity type enum <> string mapping and `toString()` to the header. Differential Revision: D97318652
ryanzhang22
force-pushed
the
export-D97318652
branch
from
ce9bb01 to
e7325f2
Compare
ryanzhang22
added a commit
to ryanzhang22/kineto
that referenced
this pull request
Mar 21, 2026
Summary: A previous version of pytorch/pytorch#177532 tried to add a pybind binding for activity_type which called `libkineto::toString(ActivityType)`. Some build configurations include the Kineto headers but do not link the compiled libkineto library, which caused an undefined symbol error at load time when `toString()` is called. To get around this -- move the activity type enum <> string mapping and `toString()` to the header. Reviewed By: scotts Differential Revision: D97318652
ryanzhang22
force-pushed
the
export-D97318652
branch
from
e7325f2 to
a0b50b9
Compare
ryanzhang22
added a commit
to ryanzhang22/kineto
that referenced
this pull request
Mar 21, 2026
Summary: A previous version of pytorch/pytorch#177532 tried to add a pybind binding for activity_type which called `libkineto::toString(ActivityType)`. Some build configurations include the Kineto headers but do not link the compiled libkineto library, which caused an undefined symbol error at load time when `toString()` is called. To get around this -- move the activity type enum <> string mapping and `toString()` to the header. Reviewed By: scotts Differential Revision: D97318652
ryanzhang22
force-pushed
the
export-D97318652
branch
from
a0b50b9 to
113689d
Compare
Summary: Pull Request resolved: pytorch#1317 A previous version of pytorch/pytorch#177532 tried to add a pybind binding for activity_type which called `libkineto::toString(ActivityType)`. Some build configurations include the Kineto headers but do not link the compiled libkineto library, which caused an undefined symbol error at load time when `toString()` is called. To get around this -- move the activity type enum <> string mapping and `toString()` to the header. Reviewed By: scotts Differential Revision: D97318652
ryanzhang22
force-pushed
the
export-D97318652
branch
from
113689d to
6115640
Compare
|
This pull request has been merged in 22cb9f1. |
smalltalkman
pushed a commit
to smalltalkman/pytorch
that referenced
this pull request
Mar 24, 2026
Contains the following changes: - [pytorch#1289](pytorch/kineto#1289) - Add `PYTORCH_TEST_WITH_ROCM=1` to profiler CI tests - [pytorch#1317](pytorch/kineto#1317) - Move activity_type enum/string map to header file - [pytorch#1315](pytorch/kineto#1315) - Update .gitignore - [pytorch#1320](pytorch/kineto#1320) - Disable `test_schedule_function_count` (segfault fix) - [pytorch#1312](pytorch/kineto#1312) - Add missing `<chrono>` header for Windows builds - [pytorch#1310](pytorch/kineto#1310) - Start flows on `hipGraphLaunch` Pull Request resolved: pytorch#178286 Approved by: https://github.com/scotts, https://github.com/Skylion007
Copilot AI
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Mar 27, 2026
Contains the following changes: - [#1289](pytorch/kineto#1289) - Add `PYTORCH_TEST_WITH_ROCM=1` to profiler CI tests - [#1317](pytorch/kineto#1317) - Move activity_type enum/string map to header file - [#1315](pytorch/kineto#1315) - Update .gitignore - [#1320](pytorch/kineto#1320) - Disable `test_schedule_function_count` (segfault fix) - [#1312](pytorch/kineto#1312) - Add missing `<chrono>` header for Windows builds - [#1310](pytorch/kineto#1310) - Start flows on `hipGraphLaunch` Pull Request resolved: #178286 Approved by: https://github.com/scotts, https://github.com/Skylion007 Co-authored-by: Xia-Weiwen <12522207+Xia-Weiwen@users.noreply.github.com>
AaronWang04
pushed a commit
to AaronWang04/pytorch
that referenced
this pull request
Mar 31, 2026
Contains the following changes: - [pytorch#1289](pytorch/kineto#1289) - Add `PYTORCH_TEST_WITH_ROCM=1` to profiler CI tests - [pytorch#1317](pytorch/kineto#1317) - Move activity_type enum/string map to header file - [pytorch#1315](pytorch/kineto#1315) - Update .gitignore - [pytorch#1320](pytorch/kineto#1320) - Disable `test_schedule_function_count` (segfault fix) - [pytorch#1312](pytorch/kineto#1312) - Add missing `<chrono>` header for Windows builds - [pytorch#1310](pytorch/kineto#1310) - Start flows on `hipGraphLaunch` Pull Request resolved: pytorch#178286 Approved by: https://github.com/scotts, https://github.com/Skylion007
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Apr 2, 2026
Contains the following changes: - [pytorch#1289](pytorch/kineto#1289) - Add `PYTORCH_TEST_WITH_ROCM=1` to profiler CI tests - [pytorch#1317](pytorch/kineto#1317) - Move activity_type enum/string map to header file - [pytorch#1315](pytorch/kineto#1315) - Update .gitignore - [pytorch#1320](pytorch/kineto#1320) - Disable `test_schedule_function_count` (segfault fix) - [pytorch#1312](pytorch/kineto#1312) - Add missing `<chrono>` header for Windows builds - [pytorch#1310](pytorch/kineto#1310) - Start flows on `hipGraphLaunch` Pull Request resolved: pytorch#178286 Approved by: https://github.com/scotts, https://github.com/Skylion007
nklshy-aws
pushed a commit
to nklshy-aws/pytorch
that referenced
this pull request
Apr 7, 2026
Contains the following changes: - [pytorch#1289](pytorch/kineto#1289) - Add `PYTORCH_TEST_WITH_ROCM=1` to profiler CI tests - [pytorch#1317](pytorch/kineto#1317) - Move activity_type enum/string map to header file - [pytorch#1315](pytorch/kineto#1315) - Update .gitignore - [pytorch#1320](pytorch/kineto#1320) - Disable `test_schedule_function_count` (segfault fix) - [pytorch#1312](pytorch/kineto#1312) - Add missing `<chrono>` header for Windows builds - [pytorch#1310](pytorch/kineto#1310) - Start flows on `hipGraphLaunch` Pull Request resolved: pytorch#178286 Approved by: https://github.com/scotts, https://github.com/Skylion007
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
A previous version of pytorch/pytorch#177532 tried to add a pybind binding for activity_type which called
libkineto::toString(ActivityType). Some build configurations include the Kineto headers but do not link the compiled libkineto library, which caused an undefined symbol error at load time whentoString()is called.To get around this -- move the activity type enum <> string mapping and
toString()to the header.Reviewed By: scotts
Differential Revision: D97318652