Support bare-metal Windows by hans00 · Pull Request #3735 · pytorch/executorch

hans00 · 2024-05-24T19:38:11Z

As title.

Support cross compile Windows using MinGW on Linux (There seems very hard to support build on Windows
Support XNNPACK
- MinGW target ARM64 require Fix build error for MinGW aarch64 cpuinfo#244
Support QNN
- x86_64 works fine

pytorch-bot · 2024-05-24T19:38:13Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3735

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This reverts commit 49add79.

digantdesai · 2024-06-14T14:19:28Z

@cccclai - can you take a look please?

cccclai · 2024-06-14T18:07:05Z

This is great! Thank you for adding this and sorry I've been missing this pull request. It's definately something we'd like to add. It may take some time to review though as it involves changes in both the the qualcomm backend and core runtime

runtime/backend/interface.cpp

JacobSzwejbka · 2024-06-14T18:20:11Z

extension/data_loader/file_data_loader.cpp

  // Read the data into the aligned address.
  size_t needed = size;
  uint8_t* buf = reinterpret_cast<uint8_t*>(aligned_buffer);
+#ifdef _WIN32


cc @dbort on the data loader changes

JacobSzwejbka · 2024-06-14T18:21:10Z

runtime/backend/interface.cpp

+#ifdef _WIN32
+
+#define SHARED_MEMORY_NAME "torch_executor_backend_registry"
+static std::shared_ptr<torch::executor::BackendRegistry> backend_reg;


cc @cccclai on the backend changes. Personally seeing shared_ptr in the core runtime is scary to me even if its gated behind windows which afaik should always have malloc and atomic available

runtime/kernel/operator_registry.cpp

dbort

Thank you so much for this PR @hans00, and sorry about the delay!

Before we review this, please help us out by splitting this into three independent PRs:

Changes to runtime/... files
Changes to extension/data_loader/... files
Changes to the qualcomm backend and related examples/ changes

If you'd like to stack these PRs on top of each other, we recommend https://github.com/ezyang/ghstack

…efault/posix.cpp`

hans00 · 2024-09-23T18:09:37Z

Sorry so late to continue on this PR.
I'm busy on other project previously.

P.S. I saw the others trying support Windows (#4661), did there still need help?

cccclai · 2024-09-29T18:01:23Z

There are some PRs merged and some are not yet. Maybe can check out the part that is finished from the description and coordinate together.

github-actions · 2025-08-27T00:51:10Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions · 2025-10-26T00:51:58Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions · 2025-12-26T00:51:15Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions · 2026-02-24T00:56:38Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

hans00 added 2 commits May 25, 2024 03:24

Use glob ignore

bf04d28

Support Windows

e58042c

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 24, 2024

hans00 added 9 commits May 25, 2024 16:20

Fix unknown type

969b612

Add ignoring files

e9f162f

Fix build for QNN

00845ea

Correct impl

f4a52a5

Fix not found symbol on Windows DLL

b2a056a

Just warning once

91f4551

Fix build for QNN

3c80ec4

Force export QnnExecuTorchAllocCustomMem, QnnExecuTorchFreeCustomMem

86e2bc6

Reduce dup-compile for custom kernels

e8192ad

hans00 marked this pull request as ready for review May 29, 2024 11:18

hans00 and others added 6 commits May 29, 2024 20:19

Use visibility instead dllexport

e99fc73

Fix QNN for Windows

4b6189f

Support Windows platform

b512236

File loader support Windows API

f41acfd

Make cmake LIB_xxx point to correct lib path

f0a8b03

Merge branch 'pytorch:main' into windows

157d275

hans00 changed the title ~~Support Windows~~ Support bare-metal Windows May 31, 2024

hans00 and others added 5 commits June 2, 2024 01:35

Move shared memory management to platform implement

49add79

Merge branch 'pytorch:main' into windows

a45e9e3

Revert "Move shared memory management to platform implement"

ba90d0b

This reverts commit 49add79.

Fix time release

06a4429

Merge branch 'pytorch:main' into windows

b0c81d4

digantdesai requested a review from dbort June 14, 2024 14:22

digantdesai assigned cccclai Jun 14, 2024

cccclai reviewed Jun 14, 2024

View reviewed changes

runtime/backend/interface.cpp Outdated Show resolved Hide resolved

JacobSzwejbka reviewed Jun 14, 2024

View reviewed changes

mergennachin requested a review from tarun292 June 14, 2024 18:24

larryliu0820 self-requested a review June 14, 2024 18:40

dbort requested changes Jun 14, 2024

View reviewed changes

hans00 added 4 commits September 23, 2024 16:06

Merge branch 'main' into windows

7ed8af1

Fix build

b013a53

Fix shared segment for MinGW

5b87e50

Merge runtime/platform/default/Windows.cpp into `runtime/platform/d…

25d7751

…efault/posix.cpp`

hans00 added 3 commits September 27, 2024 15:50

Support cross-compile

304734d

Support cross-compile for macOS

93695c4

Correct arg value when cross compile macOS

2cbb252

github-actions bot added the stale PRs inactive for over 60 days label Aug 27, 2025

Conversation

hans00 commented May 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented May 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3735

Uh oh!

digantdesai commented Jun 14, 2024

Uh oh!

cccclai commented Jun 14, 2024

Uh oh!

Uh oh!

JacobSzwejbka Jun 14, 2024

Choose a reason for hiding this comment

Uh oh!

JacobSzwejbka Jun 14, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dbort left a comment

Choose a reason for hiding this comment

Uh oh!

hans00 commented Sep 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cccclai commented Sep 29, 2024

Uh oh!

github-actions bot commented Aug 27, 2025

Uh oh!

github-actions bot commented Oct 26, 2025

Uh oh!

github-actions bot commented Dec 26, 2025

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

hans00 commented May 24, 2024 •

edited

Loading

pytorch-bot bot commented May 24, 2024 •

edited

Loading

hans00 commented Sep 23, 2024 •

edited

Loading