Skip to content

fbcode/executorch/tools/buck/constraints/BUCK - #21846

Open
nlutsenko wants to merge 1 commit into
mainfrom
export-D115998552
Open

fbcode/executorch/tools/buck/constraints/BUCK#21846
nlutsenko wants to merge 1 commit into
mainfrom
export-D115998552

Conversation

@nlutsenko

Copy link
Copy Markdown
Contributor

Differential Revision: D115998552

Differential Revision: D115998552
Copilot AI lite review requested due to automatic review settings August 14, 2026 16:46
@pytorch-bot

pytorch-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21846

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 97ceb18 with merge base 856aacb (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 14, 2026
@meta-codesync

meta-codesync Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

@nlutsenko has exported this pull request. If you are a Meta employee, you can view the originating Diff in D115998552.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the ExecuTorch Buck constraint definitions to use the Buck2 prelude macro constraint_with_aliases, consolidating multiple constraint_setting/constraint_value declarations into a more compact form while preserving the existing constraint names via aliases.

Changes:

  • Introduces constraint_with_aliases from @prelude//configurations:constraint_alias.bzl.
  • Replaces several fb_native.constraint_setting + fb_native.constraint_value blocks with constraint_with_aliases(...) definitions for kernel count, event tracer, program verification, builtin function name, and ET logging constraints.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants