Skip to content

Support scalar (non-channelwise) decay in the GDN kernels - #21844

Open
JakeStevens wants to merge 1 commit into
pytorch:mainfrom
JakeStevens:export-D114738016
Open

Support scalar (non-channelwise) decay in the GDN kernels#21844
JakeStevens wants to merge 1 commit into
pytorch:mainfrom
JakeStevens:export-D114738016

Conversation

@JakeStevens

Copy link
Copy Markdown
Contributor

Summary:
channelwise_gated_delta_rule and gated_delta_net only accepted a per-channel decay gate ([B, Hkv, T, K]).

Qwen3-Next-style GatedDeltaNet produces one gate per head ([B, Hkv, T]), so it had no path to the optimized kernels and fell back to a Python token-by-token recurrence.

This offers a replacement for the previous reverted implentation that hooks into our optimized per-channel version.

Differential Revision: D114738016

Summary:
`channelwise_gated_delta_rule` and `gated_delta_net` only accepted a per-channel decay gate (`[B, Hkv, T, K]`). 

Qwen3-Next-style GatedDeltaNet produces one gate per head (`[B, Hkv, T]`), so it had no path to the optimized kernels and fell back to a Python token-by-token recurrence.

This offers a replacement for the previous reverted implentation that hooks into our optimized per-channel version.

Differential Revision: D114738016
@pytorch-bot

pytorch-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21844

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 6021dff with merge base ea3641d (image):

NEW FAILURES - The following jobs have failed:

  • Cadence Build & Test / hifi-build / hifi4 (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • Cadence Build & Test / vision-build / vision (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 14, 2026
@meta-codesync

meta-codesync Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114738016.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants