Skip to content

Fix QNN simulator failures after HadamardTransform support - #21843

Merged
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
JakeStevens:export-D116043878
Aug 14, 2026
Merged

Fix QNN simulator failures after HadamardTransform support#21843
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
JakeStevens:export-D116043878

Conversation

@JakeStevens

@JakeStevens JakeStevens commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Summary:
With certain simulator setups, the custom hadamard transfrom could be imported multiple times.

Further, the QNN SDK version can crash due to repeated SDK version checks repeatedly loaded/unloaded libQnnHtp.so, corrupting native state. So, we now:

  1. check to guard against multiple import
  2. SDK build IDs are now cached per root

Differential Revision: D116043878

cc @cbilgin @psiddh

Summary:
With certain simulator setups, the custom hadamard transfrom could be imported multiple times.

Further, the QNN SDK version can crash  due to repeated SDK version checks repeatedly loaded/unloaded libQnnHtp.so, corrupting native state. So, we now:

1) check to guard against multiple import
2) SDK build IDs are now cached per root

Differential Revision: D116043878
@pytorch-bot

pytorch-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21843

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit a8e784b with merge base ea3641d (image):

NEW FAILURES - The following jobs have failed:

  • Cadence Build & Test / hifi-build / hifi4 (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • Cadence Build & Test / vision-build / vision (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 14, 2026
@meta-codesync

meta-codesync Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116043878.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@psiddh

psiddh commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Thanks @JakeStevens for putting this PR

@psiddh psiddh added the module: qnn Issues related to Qualcomm's QNN delegate and code under backends/qualcomm/ label Aug 14, 2026
@psiddh
psiddh requested a review from chenweng-quic August 14, 2026 16:02
@JakeStevens

Copy link
Copy Markdown
Contributor Author

@chenweng-quic et al:

I am landing due to many internal tests breaking after the hadamard PR. I believe this is preferable to a revert.

If you have any concerns with this approach, we can resolve in follow up!

Thanks

@qti-horodnic qti-horodnic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, thanks for fixing the issue rather than reverting.

@psiddh

psiddh commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Thanks @qti-horodnic for confirming. and thank you @JakeStevens for your prompt fix . Lets merge

@meta-codesync
meta-codesync Bot merged commit 287ab8b into pytorch:main Aug 14, 2026
203 of 218 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported module: qnn Issues related to Qualcomm's QNN delegate and code under backends/qualcomm/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants