Skip to content

Extend CPPCHECK scope to kernel tests#20216

Merged
perheld merged 1 commit into
pytorch:mainfrom
perheld:change-1273956
Jun 11, 2026
Merged

Extend CPPCHECK scope to kernel tests#20216
perheld merged 1 commit into
pytorch:mainfrom
perheld:change-1273956

Conversation

@perheld

@perheld perheld commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Remove the broad kernels/test CPPCHECK exclusion and keep the remaining suppressions scoped to that tree.

Kernel tests use fixture helpers, generated-style test data, and GTest macros that cppcheck cannot consistently resolve as direct use sites. Suppress those test-harness findings locally while keeping the rest of the CPPCHECK configuration active for kernels/test.

Change-Id: I033afb7b59b961a99d6716ff3faa068a0eed2f6a

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

Copilot AI review requested due to automatic review settings June 11, 2026 08:24
@perheld perheld added help wanted Extra attention is needed partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Jun 11, 2026
@pytorch-bot

pytorch-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20216

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 36 Pending, 2 Unrelated Failures

As of commit 8f4fbe5 with merge base b36bb84 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR narrows CPPCHECK exclusions by removing the broad kernels/test/** skip and replacing it with targeted cppcheck suppressions scoped to kernels/test, so kernel tests remain analyzed without being blocked by known cppcheck/GTest macro limitations.

Changes:

  • Remove kernels/test/** from CPPCHECK’s exclude_patterns so kernel tests are included in linting.
  • Add localized --suppress=...:*kernels/test/* cppcheck suppressions for common false positives in the kernel test harness.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@perheld perheld added help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Jun 11, 2026
Copilot AI review requested due to automatic review settings June 11, 2026 15:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread .lintrunner.toml
@perheld perheld removed the help wanted Extra attention is needed label Jun 11, 2026
@perheld perheld requested a review from Copilot June 11, 2026 15:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Remove the broad kernels/test CPPCHECK exclusion and keep the remaining
suppressions scoped to that tree.

Kernel tests use fixture helpers, generated-style test data, and GTest
macros that cppcheck cannot consistently resolve as direct use sites.
Suppress those test-harness findings locally while keeping the rest of
the CPPCHECK configuration active for kernels/test.

Signed-off-by: Per Held <per.held@arm.com>
Change-Id: I033afb7b59b961a99d6716ff3faa068a0eed2f6a
@perheld

perheld commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator Author

I tried to merge, got a conclict because I merged the other PR for quantized. Tried solving it in the webui (never trying that again) ending up with a whole bunch of commits that didnt make sense. Solved it locally and force pushed.

@perheld perheld merged commit 1388200 into pytorch:main Jun 11, 2026
481 of 488 checks passed
@perheld perheld deleted the change-1273956 branch June 11, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants