Extend CPPCHECK scope to kernel tests#20216
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20216
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 36 Pending, 2 Unrelated FailuresAs of commit 8f4fbe5 with merge base b36bb84 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Pull request overview
This PR narrows CPPCHECK exclusions by removing the broad kernels/test/** skip and replacing it with targeted cppcheck suppressions scoped to kernels/test, so kernel tests remain analyzed without being blocked by known cppcheck/GTest macro limitations.
Changes:
- Remove
kernels/test/**from CPPCHECK’sexclude_patternsso kernel tests are included in linting. - Add localized
--suppress=...:*kernels/test/*cppcheck suppressions for common false positives in the kernel test harness.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Remove the broad kernels/test CPPCHECK exclusion and keep the remaining suppressions scoped to that tree. Kernel tests use fixture helpers, generated-style test data, and GTest macros that cppcheck cannot consistently resolve as direct use sites. Suppress those test-harness findings locally while keeping the rest of the CPPCHECK configuration active for kernels/test. Signed-off-by: Per Held <per.held@arm.com> Change-Id: I033afb7b59b961a99d6716ff3faa068a0eed2f6a
|
I tried to merge, got a conclict because I merged the other PR for quantized. Tried solving it in the webui (never trying that again) ending up with a whole bunch of commits that didnt make sense. Solved it locally and force pushed. |
Remove the broad kernels/test CPPCHECK exclusion and keep the remaining suppressions scoped to that tree.
Kernel tests use fixture helpers, generated-style test data, and GTest macros that cppcheck cannot consistently resolve as direct use sites. Suppress those test-harness findings locally while keeping the rest of the CPPCHECK configuration active for kernels/test.
Change-Id: I033afb7b59b961a99d6716ff3faa068a0eed2f6a
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani