Skip to content

Fix get_arg to handle "self" (#20200)#20200

Closed
DrJessop wants to merge 1 commit into
pytorch:mainfrom
DrJessop:export-D108186918
Closed

Fix get_arg to handle "self" (#20200)#20200
DrJessop wants to merge 1 commit into
pytorch:mainfrom
DrJessop:export-D108186918

Conversation

@DrJessop

@DrJessop DrJessop commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Summary:

torch/fx/operator_schemas.py:112

In _torchscript_schema_to_signature_impl, self is renamed input. We need to copy this behavior in get_arg.

Reviewed By: ethansfng

Differential Revision: D108186918

@DrJessop DrJessop requested a review from kimishpatel as a code owner June 10, 2026 20:05
@pytorch-bot

pytorch-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20200

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 12 Pending

As of commit 6a1d897 with merge base fe9bc95 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 10, 2026
@meta-codesync

meta-codesync Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108186918.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync Bot changed the title Fix get_arg to handle "self" Fix get_arg to handle "self" (#20200) Jun 10, 2026
DrJessop added a commit to DrJessop/executorch that referenced this pull request Jun 10, 2026
Summary:

torch/fx/operator_schemas.py:112

In _torchscript_schema_to_signature_impl, self is renamed input. We need to copy this behavior in get_arg.

Differential Revision: D108186918
@DrJessop DrJessop force-pushed the export-D108186918 branch from e4fbaa0 to 5f7f3fc Compare June 10, 2026 21:13
Summary:

torch/fx/operator_schemas.py:112

In _torchscript_schema_to_signature_impl, self is renamed input. We need to copy this behavior in get_arg.

Reviewed By: ethansfng

Differential Revision: D108186918
@DrJessop DrJessop force-pushed the export-D108186918 branch from 5f7f3fc to 6a1d897 Compare June 11, 2026 17:01
@DrJessop DrJessop closed this Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants