Arm backend: Add TOSA dialect ARGMAX op#20112
Open
SaoirseARM wants to merge 3 commits into
Open
Conversation
Signed-off-by: Saoirse Stewart <saoirse.stewart@arm.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20112
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 19 PendingAs of commit 2495c4a with merge base fe9bc95 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Collaborator
Author
|
@pytorchbot label ciflow/trunk |
Collaborator
Author
|
@pytorchbot label 'partner: arm' |
pytorch-bot
Bot
added
the
partner: arm
Collaborator
Author
|
@pytorchbot label "release notes: arm" |
oscarandersson8218
approved these changes
Jun 9, 2026
| from torch._subclasses.fake_tensor import FakeTensorMode | ||
|
|
||
|
|
||
| def test_argmax_tosa_fp() -> None: |
Collaborator
There was a problem hiding this comment.
This file should be placed in misc/tosa_dlalect/
Collaborator
Author
There was a problem hiding this comment.
thank you! I will create a follow up PR as there are a few other testcases that are in the wrong location
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added ARGMAX tosa dialect op
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani