Skip to content

[ez][ET-VK][glsl-codegen] Use mediump precision for half-precision shader variants #19287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SS-JIA wants to merge 1 commit into
base: gh/SS-JIA/525/base
Choose a base branch
from
+7 −0
Open

[ez][ET-VK][glsl-codegen] Use mediump precision for half-precision shader variants #19287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions backends/vulkan/runtime/gen_vulkan_spv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,6 +857,13 @@ def create_shader_params(
for key, value in variant_params.items():
shader_params[key] = value

# Downgrade PRECISION to mediump for half-precision variants.
if (
shader_params.get("DTYPE") == "half"
and shader_params.get("PRECISION") == "highp"
):
shader_params["PRECISION"] = "mediump"

return shader_params

def constructOutputMap(self) -> None:
Expand Down
Loading