Skip to content

Move Cortex-M backend tests from trunk.yml to pull.yml#18308

Merged
psiddh merged 2 commits intopytorch:mainfrom
psiddh:main
Mar 19, 2026
Merged

Move Cortex-M backend tests from trunk.yml to pull.yml#18308
psiddh merged 2 commits intopytorch:mainfrom
psiddh:main

Conversation

@psiddh
Copy link
Contributor

@psiddh psiddh commented Mar 19, 2026

The test-mcu-cortex-m-backend CI job runs all Cortex-M pytests but was only in trunk.yml, meaning zero tests ran at diff time. Move it to pull.yml so regressions are caught on-diff before merge.

Authored with Claude.

The test-mcu-cortex-m-backend CI job runs all Cortex-M pytests
but was only in trunk.yml, meaning zero tests ran at diff time.
Move it to pull.yml so regressions are caught on-diff before merge.

Authored with Claude.
Copilot AI review requested due to automatic review settings March 19, 2026 06:06
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 19, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18308

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 3 Unrelated Failures

As of commit 9dff79b with merge base 569cf41 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 19, 2026
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Moves the Cortex-M backend CI job (test-mcu-cortex-m-backend) from the trunk workflow into the pull workflow so Cortex-M pytest regressions are caught during PR validation rather than only after merge.

Changes:

  • Removed test-mcu-cortex-m-backend job from .github/workflows/trunk.yml.
  • Added the same test-mcu-cortex-m-backend job to .github/workflows/pull.yml (builds the Cortex-M test runner and runs backends/cortex_m/test via pytest).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/trunk.yml Removes the Cortex-M backend test job from the trunk workflow job set.
.github/workflows/pull.yml Adds the Cortex-M backend test job to PR CI so it runs pre-merge.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@psiddh psiddh merged commit bde7360 into pytorch:main Mar 19, 2026
391 of 404 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants