Skip to content

Windows wheels: init submodules in pre-build script with OpenSSL #18262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manuelcandales merged 2 commits into from
Mar 20, 2026
Merged

Windows wheels: init submodules in pre-build script with OpenSSL #18262

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42b6952
Windows wheels: init submodules in pre-build script with OpenSSL
manuelcandales Mar 18, 2026
77989a2
Move submodule init before aarch64 workaround, deduplicate UNAME_S
manuelcandales Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .ci/scripts/wheel/pre_build_script.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,20 @@ if [[ "$(uname -m)" == "aarch64" ]]; then
echo "the file $file has been modified for atomic to use full path"
fi

# Initialize submodules here instead of during checkout so we can use OpenSSL
# on Windows (schannel fails with SEC_E_ILLEGAL_MESSAGE on some gitlab hosts).
UNAME_S=$(uname -s)
if [[ $UNAME_S == *"MINGW"* || $UNAME_S == *"MSYS"* ]]; then
git -c http.sslBackend=openssl submodule update --init
else
git submodule update --init
fi
Comment thread
manuelcandales marked this conversation as resolved.
Comment thread
manuelcandales marked this conversation as resolved.
Comment thread
manuelcandales marked this conversation as resolved.

# Clone nested submodules for tokenizers - this is a workaround for recursive
# submodule clone failing due to path length limitations on Windows. Eventually,
# we should update the core job in test-infra to enable long paths before
# checkout to avoid needing to do this.
pushd extension/llm/tokenizers
UNAME_S=$(uname -s)
if [[ $UNAME_S == *"MINGW"* || $UNAME_S == *"MSYS"* ]]; then
git -c http.sslBackend=openssl submodule update --init
else
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/build-wheels-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,6 @@ jobs:
smoke-test-script: ${{ matrix.smoke-test-script }}
trigger-event: ${{ github.event_name }}
wheel-build-params: "--verbose"
submodules: true
# Submodules are initialized in pre_build_script.sh with OpenSSL to avoid
# schannel SSL errors on Windows when cloning from non-GitHub hosts.
submodules: false
Loading