Update permute removal pass to handle binary operations, and cleanup better (#18256)#18256
Open
mcremon-meta wants to merge 3 commits intomainfrom
Open
Update permute removal pass to handle binary operations, and cleanup better (#18256)#18256mcremon-meta wants to merge 3 commits intomainfrom
mcremon-meta wants to merge 3 commits intomainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18256
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit fc5d0ba with merge base 569cf41 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96940254. |
This PR needs a
|
meta-codesync
bot
changed the title
mcremon-meta
force-pushed
the
export-D96940254
branch
from
ad581f1 to
323a2f3
Compare
mcremon-meta
added a commit
that referenced
this pull request
Mar 18, 2026
…better (#18256) Summary: Pull Request resolved: #18256 As titled. It is currently not cleaning up as much as it should, and the pass is only capable of handling single input cases. Result: from 9 to 1 (minimum by construction) permutes on Wake Gesture. Reviewed By: abeakkas Differential Revision: D96940254
meta-codesync
bot
force-pushed
the
export-D96940254
branch
from
323a2f3 to
65ef645
Compare
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 18, 2026
…better (#18256) Summary: As titled. It is currently not cleaning up as much as it should, and the pass is only capable of handling single input cases. Result: from 9 to 1 (minimum by construction) permutes on Wake Gesture. Reviewed By: abeakkas Differential Revision: D96940254
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 18, 2026
…better (#18256) Summary: As titled. It is currently not cleaning up as much as it should, and the pass is only capable of handling single input cases. Result: from 9 to 1 (minimum by construction) permutes on Wake Gesture. Reviewed By: abeakkas Differential Revision: D96940254
meta-codesync
bot
force-pushed
the
export-D96940254
branch
2 times, most recently
from
ae4c269 to
e6ca9a7
Compare
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 18, 2026
…better (#18256) Summary: As titled. It is currently not cleaning up as much as it should, and the pass is only capable of handling single input cases. Result: from 9 to 1 (minimum by construction) permutes on Wake Gesture. Reviewed By: abeakkas Differential Revision: D96940254
meta-codesync
bot
force-pushed
the
export-D96940254
branch
from
e6ca9a7 to
b35120d
Compare
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 18, 2026
…better (#18256) Summary: As titled. It is currently not cleaning up as much as it should, and the pass is only capable of handling single input cases. Result: from 9 to 1 (minimum by construction) permutes on Wake Gesture. Reviewed By: abeakkas Differential Revision: D96940254
abeakkas
approved these changes
Mar 18, 2026
Summary: Pull Request resolved: #18239 As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last. Differential Revision: D96869747 Reviewed By: hsharma35
Summary: Pull Request resolved: #18240 As titled. Calls into nnlib directly. Differential Revision: D96874522 Reviewed By: hsharma35
meta-codesync
bot
force-pushed
the
export-D96940254
branch
from
b35120d to
59626a9
Compare
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 19, 2026
…better (#18256) Summary: As titled. It is currently not cleaning up as much as it should, and the pass is only capable of handling single input cases. Result: from 9 to 1 (minimum by construction) permutes on Wake Gesture. Reviewed By: abeakkas Differential Revision: D96940254
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 19, 2026
…better (#18256) Summary: As titled. It is currently not cleaning up as much as it should, and the pass is only capable of handling single input cases. Result: from 9 to 1 (minimum by construction) permutes on Wake Gesture. Reviewed By: abeakkas Differential Revision: D96940254
…better (#18256) Summary: Pull Request resolved: #18256 As titled. It is currently not cleaning up as much as it should, and the pass is only capable of handling single input cases. Result: from 9 to 1 (minimum by construction) permutes on Wake Gesture. Reviewed By: abeakkas Differential Revision: D96940254
mcremon-meta
force-pushed
the
export-D96940254
branch
from
59626a9 to
fc5d0ba
Compare
mcremon-meta
added a commit
that referenced
this pull request
Mar 19, 2026
…better (#18256) Summary: Pull Request resolved: #18256 As titled. It is currently not cleaning up as much as it should, and the pass is only capable of handling single input cases. Result: from 9 to 1 (minimum by construction) permutes on Wake Gesture. Differential Revision: D96940254 Reviewed By: abeakkas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
As titled. It is currently not cleaning up as much as it should, and the pass is only capable of handling single input cases.
Result: from 9 to 1 (minimum by construction) permutes on Wake Gesture.
Reviewed By: abeakkas
Differential Revision: D96940254