[kernels/quantized] Enable -Werror and fix format specifier warnings

[cbilgin]

Summary:
Enable -Werror for kernels/quantized and fix format specifier mismatches that were causing -Wformat warnings when tensor dimension/size values (int64_t in ATen mode) were formatted with %zd (for ssize_t).

Mostly wanted to test the OSS flow and saw all the warnings during build
Changes:

• Add -Werror to _common_compile_options in kernels/quantized/CMakeLists.txt
• Replace %zd with ET_PRI_TENSOR_DIM for tensor .dim(), .size(), and .numel() calls in:
  • op_embedding.cpp
  • embeddingxb.cpp
  • op_choose_qparams.cpp
  • op_quantize.cpp
• Fix ET_CHECK_VALID_DIM macro in tensor_util.h to use ET_PRI_TENSOR_DIM

ET_PRI_TENSOR_DIM is the portable format specifier macro that adapts to the build mode (PRId64 for ATen mode, "zd" for portable mode).

Test Plan:
Build with: cmake --build cmake-out -j9 --target quantized_kernels Verify no -Wformat errors with -Werror enabled.

Test plan

Add Werr to CMakeLists.txt, see the build fail, apply the changes in the ops and the util and see the build succeed.

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18084

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 13 New Failures

As of commit 948c029 with merge base 4839b28 ():

NEW FAILURES - The following jobs have failed:

• Build Presets / windows (pybind) / build (gh)
  Process completed with exit code 1.
• Build Presets / windows (windows) / build (gh)
  Process completed with exit code 1.
• Lint / link-check / lint-urls (gh)
• Lint / lintrunner (gh)
  >>> Lint for runtime/core/exec_aten/util/tensor_util.h:
• pull / android / run-emulator (gh)
  The process '/usr/local/lib/android/sdk/platform-tools/adb' failed with exit code 224
• pull / test-llama-runner-linux (fp32, xnnpack+custom+qe, linux.arm64.2xlarge, executorch-ubuntu-22.04-gc... / linux-job (gh)
  /pytorch/executorch/examples/models/llama/../../../extension/llm/tokenizers/include/pytorch/tokenizers/log.h:124:43: error: inline function ‘void tokenizers::tk_pal_emit_log_message(tokenizers::tk_pal_log_level_t, const char*, const char*, size_t, const char*, size_t)’ declared weak [-Werror=attributes]
• pull / test-llama-runner-linux (fp32, xnnpack+custom+quantize_kv, linux.arm64.2xlarge, executorch-ubuntu... / linux-job (gh)
  /pytorch/executorch/examples/models/llama/../../../extension/llm/tokenizers/include/pytorch/tokenizers/log.h:124:43: error: inline function ‘void tokenizers::tk_pal_emit_log_message(tokenizers::tk_pal_log_level_t, const char*, const char*, size_t, const char*, size_t)’ declared weak [-Werror=attributes]
• pull / test-llama-runner-linux (fp32, xnnpack+quantize_kv, linux.arm64.2xlarge, executorch-ubuntu-22.04-... / linux-job (gh)
  /pytorch/executorch/examples/models/llama/../../../extension/llm/tokenizers/include/pytorch/tokenizers/log.h:124:43: error: inline function ‘void tokenizers::tk_pal_emit_log_message(tokenizers::tk_pal_log_level_t, const char*, const char*, size_t, const char*, size_t)’ declared weak [-Werror=attributes]
• pull / unittest / macos / macos-job (gh)
  export/tests/test_target_recipes.py::TestTargetRecipes::test_linear_model
• pull / unittest / windows / windows-job (gh)
  Process completed with exit code 1.
• pull / unittest-editable / windows / windows-job (gh)
  Process completed with exit code 1.
• pull / unittest-nxp-neutron / linux-job (gh)
  /pytorch/executorch/examples/nxp/executor_runner/nxp_executor_runner.cpp:441:24: error: using the result of an assignment as a condition without parentheses [-Werror,-Wparentheses]
• Test CUDA Builds / test-model-cuda-e2e (mistralai, Voxtral-Mini-3B-2507, quantized-int4-weight-only) / linux-job (gh)
  RuntimeError: Command docker exec -t fb9f4fbbe1af2cef53b60446f31414144a3f06e5b017e273474b837f70869cec /exec failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[github-actions]

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.