Qualcomm AI Engine Direct - add pass for extra padding then maxpool2d

[jethroqti]

Qualcomm AI Engine Direct - add pass for extra padding then maxpool2d

Summary:
The padding value used in max_pool2d operations differs between PyTorch and QNN implementations. PyTorch uses negative infinity, while QNN uses zero. To ensure consistent max_pool2d output across both frameworks, we handle this by padding tensor with constant in advance then doing max_pool2d without constant padding. Note that for the quantization flow, we set quant_min as the padding value. If, at runtime, there is a value smaller than quant_min, it could result in an accuracy drop.

Test plans:
python backends/qualcomm/tests/test_qnn_delegate.py TestQNNQuantizedOperator.test_qnn_backend_max_pool2d -b build-android -H ${HOST} -s ${SN} -m ${CHIPID}
python backends/qualcomm/tests/test_qnn_delegate.py TestQNNFloatingPointOperator.test_qnn_backend_max_pool2d -b build-android -H ${HOST} -s ${SN} -m ${CHIPID}

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16534

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 20 Pending

As of commit f3c142d with merge base 47dc1de ():

NEW FAILURES - The following jobs have failed:

• pull / unittest-arm-backend-with-no-deps (test_pytest_models_tosa) / linux-job (gh)
  RuntimeError: Command docker exec -t ebbb044016594f0d130a647d7dce16b5a7a704a15275e8e64ae2869f70a87bf5 /exec failed with exit code 127
• pull / unittest-arm-backend-with-no-deps (test_pytest_ops_no_target) / linux-job (gh)
  RuntimeError: Command docker exec -t 75532d1a0a4e1fcc416628f3861fc0ab1d1bc2daf130d356084a9dc599aab8f5 /exec failed with exit code 127
• pull / unittest-arm-backend-with-no-deps (test_pytest_ops_tosa) / linux-job (gh)
  RuntimeError: Command docker exec -t de714c128afbf649c7b4890580b689b087528b390b6d217db983f88537d21d63 /exec failed with exit code 127
• pull / unittest-arm-backend-with-no-deps (test_run_tosa) / linux-job (gh)
  RuntimeError: Command docker exec -t 3e477523afd803f69fa25d9a8d60537968ccd52a8bee9ad2ef0c597dadf3110e /exec failed with exit code 127

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[jethroqti]

@pytorchbot label "release notes: qualcomm"

[jethroqti]

Due to the padding value used in max_pool2d operations differs between PyTorch and QNN implementations. This pass will improve this situation. Please take a look. Thanks.
@cccclai @haowhsu-quic

[cccclai]

Hey can you address the lintrunner error?

[meta-codesync]

@cccclai has imported this pull request. If you are a Meta employee, you can view this in D90710816.

[jethroqti]

Hey can you address the lintrunner error?

Sure.

[jethroqti]

@pytorchbot label "release notes: qualcomm"