Pin ExecuTorch to the release/1.4 branch head#4434
Open
shoumikhin wants to merge 1 commit into
Open
Conversation
main pins the ExecuTorch dependency to the release/1.3 branch head (6118688a), which predates the shared extension_cuda caller-stream work. Bump the pin to the release/1.4 branch head (cd380e7aefd18c171271cc228d3a155455095219), the first ExecuTorch release line that contains both pytorch/executorch#20158 (shared extension_cuda caller-stream library) and pytorch/executorch#20498 (caller CUDA stream for H2D/D2H copies). This follows the existing convention of pinning a release-branch head commit; the new_git_repository rule takes a commit, not a branch name. The four Bazel files that pin ExecuTorch are updated identically: MODULE.bazel, docker/MODULE.bazel.docker, docker/MODULE.bazel.ngc, and toolchains/ci_workspaces/MODULE.bazel.tmpl. Swap the branch-head commit for the immutable v1.4.0 tag once ExecuTorch publishes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maincurrently pins the ExecuTorch dependency to therelease/1.3branch head(
6118688a). That commit predates the sharedextension_cudacaller-stream workin ExecuTorch, so a native build against it does not have a single shared
caller-stream instance across CUDA-capable delegates.
This change bumps the pin to the
release/1.4branch head(
cd380e7aefd18c171271cc228d3a155455095219).release/1.4is the firstExecuTorch release line that contains both required PRs:
extension_cudacaller-stream library)The bump follows the existing convention in this repo of pinning a release-branch
head commit (the
new_git_repositoryrule takes acommit, not a branch name),mirroring the current
release/1.3wording.Precedent (verified against upstream history)
The
release/1.3pin was introduced in PR #4285 (commita7e1d58abd48,2026-05-26), which converted the ExecuTorch dependency from an
env-detected
local_executorchrule to a pinnednew_git_repository. Thatcommit:
MODULE.bazel,docker/MODULE.bazel.docker,docker/MODULE.bazel.ngc,toolchains/ci_workspaces/MODULE.bazel.tmpl.(
# Pinned to the ExecuTorch release/1.3 branch head./# latest commit in release/1.3 branch/commit = "6118688a…").examples/executorch_reference_runner/README.md.This PR mirrors that exactly: same four files, same wording (with
1.3->1.4and the new SHA), README untouched. One difference in kind: #4285 established the
pin as part of a broader build-cleanup PR, whereas this is a standalone
one-line-per-file SHA + comment bump. The pin value has not been changed since
#4285, so there is no prior pure-bump commit to copy; #4285 is the file-set and
wording precedent.
Motivation
This is a general, independently useful upgrade:
mainshould track the currentExecuTorch release line, and 1.4 is now branch-cut. It also unblocks the
ExecuTorch TensorRT backend work (PR #4421), which needs the two caller-stream
PRs above and therefore cannot build against the 1.3 pin.
What changed
Four Bazel files are updated, one pin each:
MODULE.bazeldocker/MODULE.bazel.dockerdocker/MODULE.bazel.ngctoolchains/ci_workspaces/MODULE.bazel.tmplEach edit is the same:
The reference-runner guide (
examples/executorch_reference_runner/README.md)defaults
EXECUTORCH_REFtomainand is intentionally left unchanged.Follow-up
release/1.4does not yet have an immutablev1.4.0tag. Swap the branch-headcommit for the
v1.4.0tag commit once ExecuTorch publishes it. Same editsites, one SHA change per file plus the comment tweak from "release/1.4 branch
head" to the tag.
Test plan
Make the CUDA caller-stream guard a shared extension/cuda library (#20158) executorch#20158 and #20498 are both ancestors of the
release/1.4head
cd380e7a.executorch-static-build, builds//:libtorchtrtand runs.github/scripts/verify-executorch-reference-runner.shagainst the new pin;it must stay green.
main(L2 dynamo/torch-compile, JetPackwheel, RTX) are not affected by this pin and are not gating.