Skip to content

Security: Command Injection via Unsanitized Input in GitHub Scripts #4299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomaioo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Security: Command Injection via Unsanitized Input in GitHub Scripts #4299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/scripts/run_cpp_linter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import os
import json
import re

from github import Github
import subprocess
Expand All @@ -25,8 +26,10 @@
comment = """Code conforms to C++ style guidelines"""
approval = "APPROVE"
if output.returncode != 0:
lint_output = output.stdout.decode("utf-8")
lint_output = re.sub(r"[\x00-\x08\x0b\x0c\x0e-\x1f\x7f]", "", lint_output)
comment = """There are some changes that do not conform to C++ style guidelines:\n ```diff\n{}```""".format(
output.stdout.decode("utf-8")
lint_output
)
approval = "REQUEST_CHANGES"

Expand Down
Loading