Skip to content

Add support for SymInt start values in slice_scatter_decomposition#4185

Open
shahe-nv wants to merge 1 commit intopytorch:mainfrom
shahe-nv:dev1
Open

Add support for SymInt start values in slice_scatter_decomposition#4185
shahe-nv wants to merge 1 commit intopytorch:mainfrom
shahe-nv:dev1

Conversation

@shahe-nv
Copy link
Copy Markdown

Description

Add support for SymInt start values in slice_scatter_decomposition.

This fixes a crash issue when I run with ZoomASR.

Fixes # (issue): None

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Apr 14, 2026

Hi @shahe-nv!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions github-actions bot added component: lowering Issues re: The lowering / preprocessing passes component: core Issues re: The core compiler component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Apr 14, 2026
@narendasan narendasan requested review from apbose and zewenli98 April 14, 2026 17:12
elif isinstance(start, torch.SymInt):
if start < 0:
start = start + dim_size
if end is None: # Ensure end is int
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi can you have a testcase for the above?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I tested with my ZoomASR code. Without this, it will crash. After adding this it will run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: api [Python] Issues re: Python API component: core Issues re: The core compiler component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants