Add support for SymInt start values in slice_scatter_decomposition#4185
Add support for SymInt start values in slice_scatter_decomposition#4185shahe-nv wants to merge 1 commit intopytorch:mainfrom
Conversation
|
Hi @shahe-nv! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
| elif isinstance(start, torch.SymInt): | ||
| if start < 0: | ||
| start = start + dim_size | ||
| if end is None: # Ensure end is int |
There was a problem hiding this comment.
Hi can you have a testcase for the above?
There was a problem hiding this comment.
Hi, I tested with my ZoomASR code. Without this, it will crash. After adding this it will run.
Description
Add support for SymInt start values in slice_scatter_decomposition.
This fixes a crash issue when I run with ZoomASR.
Fixes # (issue): None
Type of change
Checklist: