Rather than passing a power value of 1 to the scale op, send None.#4181
Open
SandSnip3r wants to merge 1 commit intopytorch:mainfrom
Open
Rather than passing a power value of 1 to the scale op, send None.#4181SandSnip3r wants to merge 1 commit intopytorch:mainfrom
SandSnip3r wants to merge 1 commit intopytorch:mainfrom
Conversation
33c0b8a to
f52e542
Compare
f52e542 to
44ed2df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rather than passing 1 for the exponent for the
scaleop, pass None. This will save a wasteful elementwisepowop being run.This also prevents us from hitting a bug in TensorRT-RTX where
pow(x,y)wherexis negative returns NaN.Fixes #3699
Type of change
Checklist: