Skip to content

Support extra_file arg#4064

Open
cehongwang wants to merge 3 commits intomainfrom
cehongw/save-extra-args
Open

Support extra_file arg#4064
cehongwang wants to merge 3 commits intomainfrom
cehongw/save-extra-args

Conversation

@cehongwang
Copy link
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@cehongwang cehongwang requested a review from narendasan January 30, 2026 23:32
@meta-cla meta-cla bot added the cla signed label Jan 30, 2026
@github-actions github-actions bot added the component: api [Python] Issues re: Python API label Jan 30, 2026
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add a simple test to make sure the extra file is there after deserialization

Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternatively do you think its a good idea to just pass generic kwargs to the underlying save and load?

@github-actions github-actions bot added the component: tests Issues re: Tests label Jan 31, 2026
@cehongwang cehongwang force-pushed the cehongw/save-extra-args branch from b885722 to e2b04a8 Compare February 2, 2026 19:12
@cehongwang cehongwang force-pushed the cehongw/save-extra-args branch from e2b04a8 to 75e0e20 Compare February 2, 2026 21:56
@narendasan
Copy link
Collaborator

@cehongwang can you retrigger tests?

@cehongwang cehongwang force-pushed the cehongw/save-extra-args branch from 75e0e20 to eff473f Compare February 6, 2026 02:25
@cehongwang cehongwang force-pushed the cehongw/save-extra-args branch from eff473f to 29c64f9 Compare February 23, 2026 22:16
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed component: api [Python] Issues re: Python API component: tests Issues re: Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants