Skip to content

Update dataclass definitions in protocols_definition.py to not fail at class-creation time #2212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 1 commit into from
Mar 8, 2026
Merged

Update dataclass definitions in protocols_definition.py to not fail at class-creation time #2212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions conformance/tests/protocols_definition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ class Concrete4_Good6(NamedTuple):

@dataclass(frozen=False)
class Concrete4_Good7:
val1: Sequence[float] = [0]
val1: Sequence[float] = (0,)


class Concrete4_Bad1:
Expand Down Expand Up @@ -315,7 +315,7 @@ class Concrete6_Good2:

@dataclass(frozen=False)
class Concrete6_Good3:
val1: Sequence[float] = [0]
val1: Sequence[float] = (0,)


class Concrete6_Bad1:
Expand All @@ -330,7 +330,7 @@ class Concrete6_Bad2(NamedTuple):

@dataclass(frozen=True)
class Concrete6_Bad3:
val1: Sequence[float] = [0]
val1: Sequence[float] = (0,)


v6_good1: Template6 = Concrete6_Good1() # OK
Expand Down