Skip to content

[docker] Use TypedDict and SupportsGet for kwargs_from_context #16132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 5 commits into from
Aug 10, 2026
+8 −3
Merged

[docker] Use TypedDict and SupportsGet for kwargs_from_context #16132

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2f70b50
[docker] Use TypedDict and SupportsGet for kwargs_from_context
Ashid332 Aug 2, 2026
a058839
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 2, 2026
c3a23e0
Update stubs/docker/docker/context/api.pyi
Ashid332 Aug 2, 2026
e0ce7c9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 2, 2026
b51556f
[docker] Remove unused _SupportsGet protocol and imports
Ashid332 Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions stubs/docker/docker/context/api.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
from _typeshed import Incomplete
from collections.abc import Mapping, Sequence
from typing import TypedDict, type_check_only

from docker.context.context import Context
from docker.tls import TLSConfig

@type_check_only
class _ContextKwargs(TypedDict, total=False):
base_url: str
tls: TLSConfig

class ContextAPI:
DEFAULT_CONTEXT: Context
@classmethod
Expand All @@ -24,8 +29,8 @@ class ContextAPI:
def get_current_context(cls) -> Context: ...
@classmethod
def kwargs_from_context(
cls, name: str | None = None, environment: Mapping[str, str | None] | None = None
) -> dict[str, Incomplete]: ... # TODO: Use TypedDict, use SupportsGet
cls, name: str | None = None, environment: Mapping[str, str | None] | None = None # TODO: Use SupportsGet
) -> _ContextKwargs: ...
@classmethod
def set_current_context(cls, name: str = "default") -> None: ...
@classmethod
Expand Down
Loading