Skip to content

Add zizmor as pre-commit hook #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-aciek merged 3 commits into from
Jun 3, 2026
Merged

Add zizmor as pre-commit hook #139

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a557a4
Add zizmor as pre-commit hook
m-aciek Jun 2, 2026
e5f047e
Apply suggestion from @StanFromIreland
m-aciek Jun 3, 2026
10f6ae6
Fix workflow syntax in update-lint-and-build.yml
m-aciek Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pre-commit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
- cron: '0 0 * * 1,5'
env:
FORCE_COLOR: 1

permissions: {}

@StanFromIreland StanFromIreland Jun 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment applied to both places, sorry (also I can't make it a suggest because GitHub gets funky around removed lines).

jobs:
lint:
runs-on: ubuntu-latest
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/update-lint-and-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,16 @@ on:
branches:
- '*'
workflow_dispatch:

permissions: {}
Comment thread
m-aciek marked this conversation as resolved.
jobs:
update:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
version: [3.15, 3.14, 3.13, 3.12, 3.11, '3.10']
permissions:
contents: write # commit and push
steps:
- uses: styfle/cancel-workflow-action@d07a454dad7609a92316b57b23c9ccfd4f59af66 # 0.13.1
with:
Expand All @@ -32,6 +34,7 @@ jobs:
with:
ref: ${{ matrix.version }}
fetch-depth: 0
persist-credentials: false
- name: Recreate Transifex config
run: ./manage_translation.py recreate_tx_config
env:
Expand Down Expand Up @@ -81,6 +84,7 @@ jobs:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
ref: ${{ matrix.version }}
persist-credentials: false
- uses: rffontenelle/sphinx-lint-problem-matcher@4270bf50b2c93640a7cbb231c09f8e694699af9f # v1.0.0
- run: sphinx-lint

Expand All @@ -100,12 +104,14 @@ jobs:
with:
repository: python/cpython
ref: ${{ matrix.version }}
persist-credentials: false
- run: make venv
working-directory: ./Doc
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
ref: ${{ matrix.version }}
path: Doc/locales/pl/LC_MESSAGES
persist-credentials: false
- run: git pull
working-directory: ./Doc/locales/pl/LC_MESSAGES
- run: sudo apt-get update && sudo apt-get install -y librsvg2-bin
Expand Down
8 changes: 7 additions & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ repos:
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: 0c7b6c989466a93942def1f84baf36ddfcd60c83 # frozen: v0.15.14
hooks:
- id: ruff
- id: ruff-check
args: [--fix, --exit-non-zero-on-fix]
- id: ruff-format

Expand Down Expand Up @@ -34,5 +34,11 @@ repos:
- id: check-hooks-apply
- id: check-useless-excludes

- repo: https://github.com/zizmorcore/zizmor-pre-commit
rev: 9257c6050c0261b8c57e712f632dc4a8010109a9 # frozen: v1.25.2
hooks:
- id: zizmor
args: [--fix]

ci:
autoupdate_schedule: quarterly
Loading