Swap benchmark names for argparse benchmarks#470
Open
savannahostrowski wants to merge 2 commits intopython:mainfrom
Open
Swap benchmark names for argparse benchmarks#470savannahostrowski wants to merge 2 commits intopython:mainfrom
savannahostrowski wants to merge 2 commits intopython:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, I really don't know how this happened but apparently when I added the argparse benchmarks in #367, I flipped the function names.
The BENCHMARKS dict mapped "many_optionals" → bm_many_optionals and "subparsers" → bm_subparsers, so the public benchmark IDs (argparse_many_optionals, argparse_subparsers) ran the opposite workload from what their names imply.
This PR correctly renames them but obviously, this means that in the next version of pyperformance, results will be quite different. If folks have ideas on how to better handle the discontinuity, please let me know. Apologies for the churn here!
Kudos to @chris-eibl for pointing this out ❤️