Skip to content

Fix dmypy traversal of missing graph dependencies #21818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dnguy078 wants to merge 2 commits into
base: master
Choose a base branch
from
+39 −2
Open

Fix dmypy traversal of missing graph dependencies #21818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b0cd60
Fix dmypy traversal of missing graph dependencies
dnguy078 Aug 6, 2026
7e0ac76
Avoid typeshed-dependent file count in daemon regression test
dnguy078 Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions mypy/dmypy_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,7 +769,7 @@ def find_reachable_changed_modules(
state = graph[nxt.module]
ancestors = state.ancestors or []
for dep in state.dependencies + ancestors:
if dep not in seen:
if dep not in seen and dep in graph:
seen.add(dep)
worklist.append(BuildSource(graph[dep].path, graph[dep].id, followed=True))
return changed, new_files
Expand All @@ -779,7 +779,11 @@ def direct_imports(
) -> list[BuildSource]:
"""Return the direct imports of module not included in seen."""
state = graph[module[0]]
return [BuildSource(graph[dep].path, dep, followed=True) for dep in state.dependencies]
return [
BuildSource(graph[dep].path, dep, followed=True)
for dep in state.dependencies
if dep in graph
]

def find_added_suppressed(
self, graph: mypy.build.Graph, seen: set[str], search_paths: SearchPaths
Expand Down
33 changes: 33 additions & 0 deletions test-data/unit/daemon.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,3 +802,36 @@ Found 1 error in 1 file (checked 1 source file)
[file test.py]
from xml.etree.ElementTree import Element
1 + 'a'

[case testDaemonRecheckMissingGraphDependency]
-- Dropping pkg.tests from the graph leaves a stale ancestors edge behind, which
-- a later recheck used to dereference unconditionally (KeyError: 'pkg.tests').
$ dmypy start -- --no-error-summary
Daemon started
$ dmypy check src/
src/pkg/example.py:2: error: Name "x" already defined on line 1 [no-redef]
== Return code: 1
$ dmypy recheck
src/pkg/example.py:2: error: Incompatible import of "x" (imported name has type "int", local name has type "str") [assignment]
== Return code: 1
$ dmypy recheck
src/pkg/example.py:2: error: Incompatible import of "x" (imported name has type "int", local name has type "str") [assignment]
== Return code: 1
[file mypy.ini]
\[mypy]
follow_imports = normal
mypy_path = src
files = src/pkg/
exclude = (?x)(
\./.*
| tests
)
\[mypy-pkg.tests.*]
follow_imports = skip
[file src/pkg/__init__.py]
[file src/pkg/example.py]
x = "1"
from pkg.tests.test_something import x
[file src/pkg/tests/__init__.py]
[file src/pkg/tests/test_something.py]
x = 1
Loading