Skip to content

investigate and change a couple of -skips to -xfails #20889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wyattscarpenter wants to merge 1 commit into
base: master
Choose a base branch
from
Open

investigate and change a couple of -skips to -xfails #20889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test-data/unit/check-generic-subtyping.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ class E: pass
[builtins fixtures/tuple.pyi]
[out]

[case testSubtypingWithTypeImplementingGenericABCViaInheritance2-skip]
[case testSubtypingWithTypeImplementingGenericABCViaInheritance2-xfail]
from typing import TypeVar, Generic
T = TypeVar('T')
class I(Generic[T]): pass
Expand Down
2 changes: 1 addition & 1 deletion test-data/unit/merge.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1392,7 +1392,7 @@ target:
D: TypeInfo<5>
NewType: Var<4>

[case testCallable_symtable-skip]
[case testCallable_symtable-xfail]
# The TypeInfo is currently not being merged correctly
import target
[file target.py]
Expand Down
2 changes: 1 addition & 1 deletion test-data/unit/typexport-basic.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ CallExpr(5) : T`1
MemberExpr(5) : def () -> T`1
NameExpr(5) : A[T`1]

[case testGenericFunctionCallWithTypeApp-skip]
[case testGenericFunctionCallWithTypeApp-xfail]
## CallExpr|TypeApplication|NameExpr
from typing import Any, TypeVar, Tuple
T = TypeVar('T')
Expand Down