-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add --disallow-str-iteration flag #20577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
michaelm-openai
wants to merge
11
commits into
python:master
Choose a base branch
from
michaelm-openai:michaelm/disallow-str-iteration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add --disallow-str-iteration flag #20577
michaelm-openai
wants to merge
11
commits into
python:master
from
michaelm-openai:michaelm/disallow-str-iteration
+477
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
I think the apprise diff is expected given that we added a new overload. The full diagnostic is: |
This comment has been minimized.
This comment has been minimized.
9170fb1 to
473a4a1
Compare
This comment has been minimized.
This comment has been minimized.
09762a7 to
41bb4d3
Compare
This comment has been minimized.
This comment has been minimized.
8edc2d8 to
2591e4b
Compare
60e8382 to
7ca80af
Compare
for more information, see https://pre-commit.ci
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: apprise (https://github.com/caronc/apprise)
+ apprise/config/base.py:1509: note: def iter(str, /) -> Iterator[str]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11001
Related to typing python/typing#256
Expected behavior changes under this flag:
strand its subtypes are no longer treated as subtypes ofCollection,Iterable,Sequenceor protocols that extend them. Assignment and argument passing will be treated as errors.iter()method has an additional overload which acceptsstr. This is the recommended way to iterate over characters when this flag is enabled.strto subtypes ofContainer, such asCollectionwill not report a conflict on the__contains__method, since this introduces noise. It is known thatstrdoes not conform to theContainerprotocol due to its incompatible signature for__contains__method.isinstance(foo, Sequence), etc. will narrowfootostr | Sequence[Any], etc. to be consistent with runtime behavior. That implies in order to iterate throughfoo, one must checkisinstance(foo, Sequence) and not isinstance(foo, str).