Skip to content

gh-81954: Use lazy import warnings in zipfile - #155326

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:zipfile_warnings
Aug 7, 2026
Merged

gh-81954: Use lazy import warnings in zipfile#155326
vstinner merged 1 commit into
python:mainfrom
vstinner:zipfile_warnings

Conversation

@vstinner

@vstinner vstinner commented Aug 7, 2026

Copy link
Copy Markdown
Member

Since there is "lazy import warnings" at top level, it's no longer needed to import warnings explicitly in other places.

Since there is "lazy import warnings" at top level, it's no longer
needed to import warnings explicitly in other places.
@vstinner

vstinner commented Aug 7, 2026

Copy link
Copy Markdown
Member Author

@cmaloney: Would you mind to review my change?

After I merged your PR gh-152354, I looked at zipfile (when testing your change), and I noticed these "import warnings" lines which are no longer needed.

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner
vstinner merged commit 7922b67 into python:main Aug 7, 2026
58 checks passed
@vstinner
vstinner deleted the zipfile_warnings branch August 7, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants