gh-64660: Do not hardcode the name of the returned variable - #155268
Merged
Conversation
Return converters had to hardcode "return_value", because declare() sets data.return_value to the variable which receives the value returned by the impl. The name of the variable returned by the parsing function is now available as data.parser_retval.
serhiy-storchaka
requested review from
a team,
AA-Turner and
erlend-aasland
as code owners
August 6, 2026 08:45
mbeijen
pushed a commit
to mbeijen/cpython
that referenced
this pull request
Aug 14, 2026
…thonGH-155268) Return converters had to hardcode "return_value", because declare() sets data.return_value to the variable which receives the value returned by the impl. The name of the variable returned by the parsing function is now available as data.parser_retval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data.return_valuekeeps its meaning -- the variable which receives the value returned by the impl, whichdeclare()and custom return converters repoint. The name of the variable returned by the parsing function is now available asdata.parser_retval, so that return converters no longer need to hardcode it.The return converters in
PC/msvcrtmodule.care updated as well;wchar_t_return_converterhardcoded both names.The generated code is not changed.
_return_value#64660