gh-143768: Replace a dangling interpreter symlink when creating a venv - #150985
gh-143768: Replace a dangling interpreter symlink when creating a venv#150985claydugo wants to merge 4 commits into
Conversation
Co-authored-by: Brett Cannon <brett@python.org>
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Thanks for the review! Just pushed a doc update |
Documentation build overview
|
If you're ready for another review then don't forget to follow the instructions from the bot about how to notify folks you're ready. |
|
Oops, glazed right over that. Sorry. I have made the requested changes; please review again |
|
Thanks for making the requested changes! @brettcannon: please review the changes made to this pull request. |
A dangling interpreter symlink in the target directory caused
venvto crash with--copiesand to silently leave the broken link in place with symlinks.symlink_or_copynow unlinks a dangling destination symlink first, matching how a stale regular file is already replaced on re-run.Supersedes #143770, which got stuck in a wedged change-detection state after a bad merge via the GitHub UI.