Convert PyBool_Check, PyBytes_Check & PyBytes_CheckExact macro to a function

[bschoenmaeckers]

As discussed at https://discuss.python.org/t/c-api-add-py-getbuildintype-and-py-getbuildintypeborrowed/107010/12.

This converts the first type check macro to a function export instead when compiling for the limited api.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[python-cla-bot]

All commit authors signed the Contributor License Agreement.

[read-the-docs-community]

Documentation build overview

📚 cpython-previews | 🛠️ Build #32606787 | 📁 Comparing 63e3c03 against main (5784119)

  🔍 Preview build  

4 files changed

± c-api/bool.html
± c-api/stable.html
± whatsnew/3.16.html
± whatsnew/changelog.html

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[encukou]

These should be at the end of the file, so all the internal implementations see the macro version.

---

These will become repetitive enough that I'd prefer condensed formatting (per the first rule in PEP 7):

// Implementations for the Stable ABI

#undef PyBool_Check
int PyBool_Check(PyObject *x) { return Py_IS_TYPE(x, &PyBool_Type); }

But @vstinner might disagree with that :)

[bschoenmaeckers]

I've moved it to the end of the file and used the condensed formatting.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[encukou]

PyBool_Check looks good; the next step would be e.g. PyBytes_Check & PyBytes_CheckExact, to show how this will look with the subclassable types.

[bschoenmaeckers]

PyBool_Check looks good; the next step would be e.g. PyBytes_Check & PyBytes_CheckExact, to show how this will look with the subclassable types.

Great! Do you want me to do it in this PR?

[encukou]

Yeah, it would fit the title ;)
Thanks!

[vstinner]

I don't get the rationale for hiding the implementation details of these macros. I don't think that it's worth it.

[github-actions]

This PR is stale because it has been open for 90 days with no activity.

[vstinner]

I don't get the rationale for hiding the implementation details of these macros. I don't think that it's worth it.

@bschoenmaeckers: Can you fix the issue in RustPython instead? See https://discuss.python.org/t/c-api-add-py-getbuildintype-and-py-getbuildintypeborrowed/107010/17.