gh-148608: Unbind classmethods in LOAD_ATTR_CLASS#148610
Open
Fidget-Spinner wants to merge 5 commits intopython:mainfrom
Open
gh-148608: Unbind classmethods in LOAD_ATTR_CLASS#148610Fidget-Spinner wants to merge 5 commits intopython:mainfrom
Fidget-Spinner wants to merge 5 commits intopython:mainfrom
Conversation
kumaraditya303
approved these changes
Apr 15, 2026
Member
Author
|
Hmm, I think I'm going to skip news as this change (in theory) should not be observable at all from the user's perspective, even on the perf side on the normal interpreter. A better way would be to load the method directly via _PyType_Lookup if we determine it's a type. However, that requires a lot of duplicated code and factoring of the _PyObject_GetMethod function. It's also a lot harder to get right. However, a working implementation of that would significantly improve FT scaling for |
Member
Author
|
I think I have a better solution of handling this at specialization time. Let me investigate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CALL_BOUND_METHOD_EXACT_ARGSnow becomesCALL_PY_EXACT_ARGSforcls.classmethod()calls.