gh-145239: Accept unary plus literal pattern#148566
Open
johnslavik wants to merge 8 commits intopython:mainfrom
Open
gh-145239: Accept unary plus literal pattern#148566johnslavik wants to merge 8 commits intopython:mainfrom
johnslavik wants to merge 8 commits intopython:mainfrom
Conversation
Add '+' alternatives to signed_number and signed_real_number grammar rules, mirroring how unary minus is already handled. Unary plus is a no-op on numbers so the value is returned directly without wrapping in a UnaryOp node.
Mirror the existing negative-number tests (095-110) for positive numbers: integers, floats, imaginary, and complex patterns.
Assuming astral-sh/ruff#16394 (comment) is still correct, there's no other way around
Member
|
You may also want to update this doc. |
Member
Author
|
Fun fact is that technically |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LMK if you'd like the tests shortened. I copy-pasted the existing cases, but I'm tempted to shorten it drastically. You decide!
For example, I don't see the point in
self.assertEqualonx.matchsyntax error for unary addition in pattern #145239