gh-148535: Don't use gcc -fprofile-update=atomic flag on i686#148554
Open
vstinner wants to merge 1 commit intopython:mainfrom
Open
gh-148535: Don't use gcc -fprofile-update=atomic flag on i686#148554vstinner wants to merge 1 commit intopython:mainfrom
vstinner wants to merge 1 commit intopython:mainfrom
Conversation
The -fprofile-update=atomic flag was added to fix a random GCC internal error on PGO build (pythongh-145801) caused by corruption of profile data (.gcda files). The problem is that it makes the PGO build way slower (up to 47x slower) on i686. Since the GCC internal error was not seen on i686 so far, don't use -fprofile-update=atomic on i686.
vstinner
requested review from
AA-Turner,
corona10,
emmatyping and
erlend-aasland
as code owners
vstinner
added
needs backport to 3.13
| ],[ac_cv_i686=no],[ac_cv_i686=yes]) | ||
| ]) | ||
|
|
||
| PGO_PROF_GEN_FLAG="-fprofile-generate" |
Member
There was a problem hiding this comment.
Do we need to do PGO_PROF_GEN_FLAG="PGO_PROF_GEN_FLAG -fprofile-generate" (i forgot the proper substitution) or is this something that won't be set by user?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The -fprofile-update=atomic flag was added to fix a random GCC internal error on PGO build (gh-145801) caused by corruption of profile data (.gcda files). The problem is that it makes the PGO build way slower (up to 47x slower) on i686. Since the GCC internal error was not seen on i686 so far, don't use -fprofile-update=atomic on i686.