gh-148464: Add missing __ctype_le/be__ attributes for complex types in the ctype module#148485
Open
skirpichev wants to merge 5 commits intopython:mainfrom
Open
gh-148464: Add missing __ctype_le/be__ attributes for complex types in the ctype module#148485skirpichev wants to merge 5 commits intopython:mainfrom
__ctype_le/be__ attributes for complex types in the ctype module#148485skirpichev wants to merge 5 commits intopython:mainfrom
Conversation
…ex types in the ctype module
skirpichev
force-pushed
the
add-F/D_sw/148464
branch
from
226aaab to
1e45180
Compare
eendebakpt
reviewed
Apr 14, 2026
eendebakpt
reviewed
Apr 14, 2026
encukou
reviewed
Apr 14, 2026
| D_get_sw(void *ptr, Py_ssize_t size) | ||
| { | ||
| assert(NUM_BITS(size) || (size == 2*sizeof(double))); | ||
| return PyComplex_FromDoubles(PyFloat_Unpack8(ptr, PY_BIG_ENDIAN), |
Member
There was a problem hiding this comment.
Could you add error handling for the unpacks here and PyFloat_Unpack4 below?
if (x == -1.0 && PyErr_Occurred()) {
I'd be happier if ctypes didn't rely on an undocumented implementation detail here.
Member
Author
There was a problem hiding this comment.
Why undocumented? It's documented and widely used across the CPython codebase, e.g. in same file.
Old code relying on implementation detail, that elements[1] for the FFI_TYPE_COMPLEX was never read. But this type actually shares same assumption as the FFI_TYPE_STRUCT: the elements field is a NULL-terminated array of pointers to ffi_type objects. So far for primitive types - only complex types have this struct field as non-NULL (two element array).
Member
Author
|
BTW, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__ctype_{be,le}__attributes missing forctypes.c_*_complextypes #148464