GH-145278: freeze encodings (partially) and linecache#145279
Open
FFY00 wants to merge 2 commits intopython:mainfrom
Open
GH-145278: freeze encodings (partially) and linecache#145279FFY00 wants to merge 2 commits intopython:mainfrom
FFY00 wants to merge 2 commits intopython:mainfrom
Conversation
Signed-off-by: Filipe Laíns <lains@riseup.net>
FFY00
requested review from
AA-Turner,
emmatyping,
ericsnowcurrently and
erlend-aasland
as code owners
Member
Author
|
This makes it so that we don't fail at startup if the stdlib isn't in $ PYTHONHOME=nonsense PYTHON_FROZEN_MODULES=on ./python -c 'print("foo!")'
foo!Which while is good, doesn't make it obvious there's an issue. GH-145274 adds a nice warning, $ PYTHONHOME=nonsense PYTHON_FROZEN_MODULES=on ./python -c 'print("foo!")'
WARN: Could not find the standard library directory! The Python 'home' directory was set to 'nonsense', is this correct?
foo! |
Signed-off-by: Filipe Laíns <lains@riseup.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.