Skip to content

gh-144228: Remove DIRENT build flag comment #144229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnslavik wants to merge 1 commit into from
Closed

gh-144228: Remove DIRENT build flag comment #144229

johnslavik wants to merge 1 commit into from

Conversation

@johnslavik
Copy link
Member

@johnslavik johnslavik commented Jan 26, 2026 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jan 26, 2026
Closed
12 tasks
@johnslavik johnslavik marked this pull request as ready for review January 26, 2026 07:12
@johnslavik johnslavik requested a review from a team as a code owner January 26, 2026 07:12
@johnslavik
Copy link
Member Author

johnslavik commented Jan 27, 2026

We can still consider merging this as it poses zero risk and reduces confusion.

@encukou
Copy link
Member

encukou commented Jan 27, 2026

We generally don't merge pure cosmetic changes.

@encukou encukou closed this Jan 27, 2026
@johnslavik johnslavik deleted the 144228/remove-dirent branch January 27, 2026 08:57
@johnslavik
Copy link
Member Author

johnslavik commented Jan 27, 2026 •
edited
Loading

We generally don't merge pure cosmetic changes.

Yeah, I guess that it doesn't really make much sense to merge this in isolation from the general idea of #144228. Thank you for your time reviewing and considering this. 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnslavik @encukou