gh-144100: Fix crash for POINTER(str) used in ctypes argtypes #144108
+20
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
@vstinner This is my proposed solution if you have time please review it. |
vstinner
reviewed
Jan 23, 2026
Comment on lines
478
to
479
| with self.assertWarns(DeprecationWarning): | ||
| BadType = ctypes.POINTER("BugTrigger") |
Member
There was a problem hiding this comment.
I would prefer to avoid deprecated code path. You should be able to use:
Suggested change
| with self.assertWarns(DeprecationWarning): | |
| BadType = ctypes.POINTER("BugTrigger") | |
| class BadType(ctypes._Pointer): | |
| # _type_ is not defined on purpose | |
| pass |
Comment on lines
481
to
488
| if os.name == "nt": | ||
| libc = ctypes.WinDLL("kernel32.dll") | ||
| func = libc.GetCurrentProcessId | ||
| else: | ||
| libc = ctypes.CDLL(None) | ||
| func = libc.getpid | ||
|
|
||
| func.argtypes = (BadType,) |
Member
There was a problem hiding this comment.
You can use the Python C API:
Suggested change
| if os.name == "nt": | |
| libc = ctypes.WinDLL("kernel32.dll") | |
| func = libc.GetCurrentProcessId | |
| else: | |
| libc = ctypes.CDLL(None) | |
| func = libc.getpid | |
| func.argtypes = (BadType,) | |
| func = ctypes.pythonapi.Py_GetVersion | |
| func.argtypes = (BadType,) |
| ptr.set_type(c_int) | ||
| self.assertIs(ptr._type_, c_int) | ||
|
|
||
| class TestPointerStringProto(unittest.TestCase): |
Member
There was a problem hiding this comment.
I would prefer to add the test to the end of PointersTestCase, instead of adding a new test case.
| import gc | ||
| import sys | ||
| import unittest | ||
| import os |
Member
There was a problem hiding this comment.
This import can be removed with my proposed code.
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes a crash in
ctypesthat occur when a deprecatedPOINTER(str)type was used inargtypes.When such a pointer type was encountered during argument conversion,
ctypeswould hit an internal assertion and abort the interpreter in debug builds.This PR replaces the assertion with proper error handling and raises a Python exception instead.