gh-143919: Reject control characters in http cookies #143920
Merged
+80
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethmlarson
added
type-security
johnslavik
reviewed
Jan 16, 2026
Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
sobolevn
reviewed
Jan 16, 2026
Co-authored-by: sobolevn <mail@sobolevn.me>
Yhg1s
approved these changes
Jan 19, 2026
Yhg1s
changed the title
|
Thanks @sethmlarson for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11, 3.12, 3.13, 3.14. |
|
Sorry, @sethmlarson, I could not cleanly backport this to |
sethmlarson
removed
needs backport to 3.10
sethmlarson
removed
needs backport to 3.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.