-
-
Notifications
You must be signed in to change notification settings - Fork 34k
gh-138762: Move inclusion of Include/dynamic_annotations.h outside extern "C"
#138763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d1d8b42
Move Include/dynamic_annotations.h to be outside exten "C"
clin1234 5acdfc6
📜🤖 Added by blurb_it.
blurb-it[bot] f339844
Apply suggestion from @sobolevn
clin1234 fe05c5d
Delete .devcontainer/devcontainer.json
clin1234 9d0946d
Delete .devcontainer/devcontainer.json
clin1234 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,83 +1 @@ | ||
| { | ||
| "image": "ghcr.io/python/devcontainer:latest", | ||
| "onCreateCommand": [ | ||
| // Install common tooling. | ||
| "dnf", | ||
| "install", | ||
| "-y", | ||
| // For umask fix below. | ||
| "/usr/bin/setfacl" | ||
| ], | ||
| "updateContentCommand": { | ||
| // Using the shell for `nproc` usage. | ||
| "python": "./configure --config-cache --with-pydebug && make -s -j `nproc`", | ||
| "docs": [ | ||
| "make", | ||
| "--directory", | ||
| "Doc", | ||
| "venv", | ||
| "html" | ||
| ] | ||
| }, | ||
| "postCreateCommand": { | ||
| // https://github.com/orgs/community/discussions/26026 | ||
| "umask fix: workspace": ["sudo", "setfacl", "-bnR", "."], | ||
| "umask fix: /tmp": ["sudo", "setfacl", "-bnR", "/tmp"] | ||
| }, | ||
| "customizations": { | ||
| "vscode": { | ||
| "extensions": [ | ||
| // Highlighting for Parser/Python.asdl. | ||
| "brettcannon.zephyr-asdl", | ||
| // Highlighting for configure.ac. | ||
| "maelvalais.autoconf", | ||
| // C auto-complete. | ||
| "ms-vscode.cpptools", | ||
| // To view HTML build of docs. | ||
| "ms-vscode.live-server", | ||
| // Python auto-complete. | ||
| "ms-python.python" | ||
| ], | ||
| "settings": { | ||
| "C_Cpp.default.compilerPath": "/usr/bin/clang", | ||
| "C_Cpp.default.cStandard": "c11", | ||
| "C_Cpp.default.defines": [ | ||
| "CONFIG_64", | ||
| "Py_BUILD_CORE" | ||
| ], | ||
| "C_Cpp.default.includePath": [ | ||
| "${workspaceFolder}/*", | ||
| "${workspaceFolder}/Include/**" | ||
| ], | ||
| // https://github.com/microsoft/vscode-cpptools/issues/10732 | ||
| "C_Cpp.errorSquiggles": "disabled", | ||
| "editor.insertSpaces": true, | ||
| "editor.rulers": [ | ||
| 80 | ||
| ], | ||
| "editor.tabSize": 4, | ||
| "editor.trimAutoWhitespace": true, | ||
| "files.associations": { | ||
| "*.h": "c" | ||
| }, | ||
| "files.encoding": "utf8", | ||
| "files.eol": "\n", | ||
| "files.insertFinalNewline": true, | ||
| "files.trimTrailingWhitespace": true, | ||
| "python.analysis.diagnosticSeverityOverrides": { | ||
| // Complains about shadowing the stdlib w/ the stdlib. | ||
| "reportShadowedImports": "none", | ||
| // Doesn't like _frozen_importlib. | ||
| "reportMissingImports": "none" | ||
| }, | ||
| "python.analysis.extraPaths": [ | ||
| "Lib" | ||
| ], | ||
| "python.defaultInterpreterPath": "./python", | ||
| "[restructuredtext]": { | ||
| "editor.tabSize": 3 | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/C_API/2025-09-10-17-49-54.gh-issue-138762.1rG6GQ.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Fix linking of the free-threaded build with C++ compiler. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you revert this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, meant to close this