Skip to content

gh-102967: Don't pass None to seek(), simply truncate from the current position. - #102968

Merged
serhiy-storchaka merged 16 commits into
python:mainfrom
aaron-fl:issue-102967
Aug 13, 2026
Merged

gh-102967: Don't pass None to seek(), simply truncate from the current position.#102968
serhiy-storchaka merged 16 commits into
python:mainfrom
aaron-fl:issue-102967

Conversation

@aaron-fl

@aaron-fl aaron-fl commented Mar 23, 2023

Copy link
Copy Markdown
Contributor

gh-102967: Don't pass None to seek(), simply truncate from the current position.

@bedevere-bot

bedevere-bot commented Mar 23, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot bedevere-bot mentioned this pull request Mar 23, 2023
Closed
@ghost

ghost commented Mar 23, 2023 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@arhadthedev arhadthedev added the tests Tests in the Lib/test dir label Mar 23, 2023
@AlexWaygood AlexWaygood added stdlib Standard Library Python modules in the Lib/ directory and removed tests Tests in the Lib/test dir labels Mar 23, 2023
@aaron-fl

aaron-fl commented Mar 24, 2023

Copy link
Copy Markdown
Contributor Author

Although, as I look at it more. Why would we want the behavior of _SpoofOut.truncate() to differ from the standard implementation? IMO the whole method should be removed. But that might break more things.

@python-cla-bot

python-cla-bot Bot commented Apr 18, 2025 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@github-actions

github-actions Bot commented Apr 12, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 12, 2026
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Aug 12, 2026
serhiy-storchaka
serhiy-storchaka reviewed Aug 13, 2026
View reviewed changes
Comment thread Lib/doctest.py Outdated
Comment thread Misc/NEWS.d/next/Library/2023-03-23-19-47-05.gh-issue-102967.gfIYkN.rst Outdated
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Aug 13, 2026
serhiy-storchaka and others added 2 commits August 13, 2026 10:16
@serhiy-storchaka
Fix bug in doctest._SpoofOut.truncate method
332690a
@serhiy-storchaka @claude
Fix the line endings in the NEWS entry
09fc43a 
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@serhiy-storchaka
serhiy-storchaka merged commit 7586115 into python:main Aug 13, 2026
51 checks passed
@miss-islington-app

miss-islington-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

Thanks @aaron-fl for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

GH-155664 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Aug 13, 2026
@bedevere-app

bedevere-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

GH-155665 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Aug 13, 2026
@bedevere-app

bedevere-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

GH-155666 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Aug 13, 2026
serhiy-storchaka pushed a commit that referenced this pull request Aug 13, 2026
@miss-islington @aaron-fl
[3.13] gh-102967: Don't pass None to seek(), simply truncate from the…
79b5327 
… current position (GH-102968) (GH-155666)

(cherry picked from commit 7586115)

Co-authored-by: aaron-fl <43595516+aaron-fl@users.noreply.github.com>
serhiy-storchaka pushed a commit that referenced this pull request Aug 13, 2026
@miss-islington @aaron-fl
[3.14] gh-102967: Don't pass None to seek(), simply truncate from the…
e174896 
… current position (GH-102968) (GH-155665)

(cherry picked from commit 7586115)

Co-authored-by: aaron-fl <43595516+aaron-fl@users.noreply.github.com>
mbeijen pushed a commit to mbeijen/cpython that referenced this pull request Aug 14, 2026
@aaron-fl @mbeijen
pythongh-102967: Don't pass None to seek(), simply truncate from the …
383f91d 
…current position (pythonGH-102968)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

Assignees

No one assigned

Labels

stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aaron-fl @bedevere-bot @serhiy-storchaka @arhadthedev @AlexWaygood