refactor: Split packagesettings module into a package#953
Merged
mergify[bot] merged 1 commit intopython-wheel-build:mainfrom Mar 19, 2026
Merged
refactor: Split packagesettings module into a package#953mergify[bot] merged 1 commit intopython-wheel-build:mainfrom
mergify[bot] merged 1 commit intopython-wheel-build:mainfrom
Conversation
Collaborator
Author
|
@Mergifyio rebase |
The `packagesettings` module has grown to over 1,200 lines of code. With upcoming plans to improve resolver, downloader, and patching, the code is going to grow even more. Split the module into a package with several private modules. The public interface of the `fromager.packagesettings` is mostly staying the same. Only one monkey-patching case for testing had to be changed. Co-Authored-By: Claude <claude@anthropic.com> Signed-off-by: Christian Heimes <cheimes@redhat.com>
Contributor
✅ Branch has been successfully rebased |
tiran
force-pushed
the
refactor-packagesettings
branch
from
6449998 to
0379923
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
packagesettingsmodule has grown to over 1,200 lines of code. With upcoming plans to improve resolver, downloader, and patching, the code is going to grow even more.Split the module into a package with several private modules. The public interface of the
fromager.packagesettingsis mostly staying the same. Only one monkey-patching case for testing had to be changed.