Skip to content

fix: remove warning about missing hostname command#792

Merged
mergify[bot] merged 2 commits intopython-wheel-build:mainfrom
tiran:no-hostname-warning
Sep 25, 2025
Merged

fix: remove warning about missing hostname command#792
mergify[bot] merged 2 commits intopython-wheel-build:mainfrom
tiran:no-hostname-warning

Conversation

@tiran
Copy link
Copy Markdown
Collaborator

@tiran tiran commented Sep 25, 2025

Partly revert e9bd424. The warning about missing hostname command is causing issues and breaks get_dependencies call.

Log a better error message when JSON de-serialization fails in BuildEnvironment.get_distribution() call.

Do not fail when debug log call with installed distributions is failing. The error is not fatal.

Partly revert e9bd424. The warning
about missing `hostname` command is causing issues and breaks
`get_dependencies` call.

Signed-off-by: Christian Heimes <cheimes@redhat.com>
Log a better error message when JSON de-serialization fails in
`BuildEnvironment.get_distribution()` call.

Do not fail when debug log call with installed distributions is failing.
The error is not fatal.

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran tiran requested a review from a team as a code owner September 25, 2025 13:40
Copy link
Copy Markdown
Contributor

@rd4398 rd4398 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify Bot merged commit e88a7c2 into python-wheel-build:main Sep 25, 2025
111 checks passed
@tiran tiran deleted the no-hostname-warning branch September 25, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants