Skip to content

feat(lint-requirements): make resolving requirements optional#790

Merged
mergify[bot] merged 1 commit intopython-wheel-build:mainfrom
tiran:optional-resolve-requirements
Sep 25, 2025
Merged

feat(lint-requirements): make resolving requirements optional#790
mergify[bot] merged 1 commit intopython-wheel-build:mainfrom
tiran:optional-resolve-requirements

Conversation

@tiran
Copy link
Copy Markdown
Collaborator

@tiran tiran commented Sep 25, 2025

In downstream we are having issues with new resolve version feature of the linter. Some packages need extra configuration to resolve versions from git repos.

  • disable resolving of requirements by default
  • add flag --resolve-requirements (default: False) to enable resolving
  • collect all failures and print a summary at the end
  • refactor code a bit

@tiran tiran requested a review from a team as a code owner September 25, 2025 10:34
@mergify mergify Bot added the ci label Sep 25, 2025
@tiran
Copy link
Copy Markdown
Collaborator Author

tiran commented Sep 25, 2025

The change resolves the linting issue in downstream:

# fromager --no-network-isolation lint-requirements collections/*/*/constraints.txt collections/*/*/requirements.txt 
10:33:14 INFO loading settings from /work/overrides/settings.yaml
Resolve requirements: False
Successfully validated 16 file(s).

I'm still getting the expected errors with fromager --no-network-isolation lint-requirements --resolve-requirements ...

In downstream we are having issues with new resolve version feature of
the linter. Some packages need extra configuration to resolve versions
from git repos.

- disable resolving of requirements by default
- add flag `--resolve-requirements` (default: False) to enable resolving
- collect all failures and print a summary at the end
- refactor code a bit

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran tiran force-pushed the optional-resolve-requirements branch from 814a950 to 44bc4b1 Compare September 25, 2025 10:35
Copy link
Copy Markdown
Contributor

@EmilienM EmilienM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@rd4398 rd4398 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@mergify mergify Bot merged commit b294a4a into python-wheel-build:main Sep 25, 2025
112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants