fix: improve network isolation#789
Merged
mergify[bot] merged 1 commit intopython-wheel-build:mainfrom Sep 25, 2025
Merged
Conversation
Use `check_output` instead of `check_call` in network isolation detection helper. It captures the output to stdout and avoid spurious warnings about missing commands. Add debug code to `run_network_isolation.sh` script. The script detects missing `ip` command and prints debug message + arguments on error. Signed-off-by: Christian Heimes <cheimes@redhat.com>
LalatenduMohanty
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
check_outputinstead ofcheck_callin network isolation detection helper. It captures the output to stdout and avoid spurious warnings about missing commands.Add debug code to
run_network_isolation.shscript. The script detects missingipcommand and prints debug message + arguments on error.